NeroReflex/mesa
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

i965/fs: Avoid constant propagation when the type sizes don't match.

Browse source 
The case where the source type of the instruction is smaller than the
immediate type could be handled by calculating the portion of the
immediate read by the instruction (assuming that the source channels
are aligned with the destination channels of the copy) and then
representing the same value as an immediate of the source type
(assuming such an immediate type exists), but the code below doesn't
do that, so just bail for the moment.

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
This commit is contained in:
Francisco Jerez 2016-05-19 21:32:14 -07:00
parent 52cc80d859
commit 0bc5ad8d19
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp
View file

@ -538,6 +538,14 @@ fs_visitor::try_constant_propagate(fs_inst *inst, acp_entry *entry)
entry->dst, entry->regs_written))
continue;
/* If the type sizes don't match each channel of the instruction is
* either extracting a portion of the constant (which could be handled
* with some effort but the code below doesn't) or reading multiple
* channels of the source at once.
*/
if (type_sz(inst->src[i].type) != type_sz(entry->dst.type))
continue;
fs_reg val = entry->src;
val.type = inst->src[i].type;