NeroReflex/mesa
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

nouveau/winsys: fix bda heap leak.

Browse source 
found with valgrind.

Fixes: b4cfac64c8 ("nvk: Add a separate VMA heap for BDA capture/replay")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27712>
(cherry picked from commit fd04c14306882693e5ba95fd7a128800c3069f5b)
This commit is contained in:
Dave Airlie 2024-02-21 14:28:14 +10:00 • committed by Eric Engestrom
parent 0f8d77fc04
commit 2bc85abbf2
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -2054,7 +2054,7 @@
"description": "nouveau/winsys: fix bda heap leak.", "description": "nouveau/winsys: fix bda heap leak.",
"nominated": true, "nominated": true,
"nomination_type": 1, "nomination_type": 1,
"resolution": 0, "resolution": 1,
"main_sha": null, "main_sha": null,
"because_sha": "b4cfac64c8a98026d3698a2231c09a21bbe5a2f4", "because_sha": "b4cfac64c8a98026d3698a2231c09a21bbe5a2f4",
"notes": null "notes": null

2
src/nouveau/winsys/nouveau_device.c
View file

@ -351,6 +351,7 @@ nouveau_ws_device_new(drmDevicePtr drm_device)
out_err: out_err:
if (device->has_vm_bind) { if (device->has_vm_bind) {
util_vma_heap_finish(&device->vma_heap); util_vma_heap_finish(&device->vma_heap);
util_vma_heap_finish(&device->bda_heap);
simple_mtx_destroy(&device->vma_mutex); simple_mtx_destroy(&device->vma_mutex);
} }
if (ver) if (ver)
@ -372,6 +373,7 @@ nouveau_ws_device_destroy(struct nouveau_ws_device *device)
if (device->has_vm_bind) { if (device->has_vm_bind) {
util_vma_heap_finish(&device->vma_heap); util_vma_heap_finish(&device->vma_heap);
util_vma_heap_finish(&device->bda_heap);
simple_mtx_destroy(&device->vma_mutex); simple_mtx_destroy(&device->vma_mutex);
} }