NeroReflex/mesa
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

gallium/auxiliary: replace call to dup(2) with fcntl(F_DUPFD_CLOEXEC)

Browse source 
Without this fix, duplicated file descriptors leak into child processes.
See commit aaac913e90 for one instance
where the same fix was employed.

Cc: <mesa-stable@lists.freedesktop.org>
Signed-off-by: Matt Whitlock <freedesktop@mattwhitlock.name>
Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
This commit is contained in:
Matt Whitlock 2016-10-01 23:49:42 -04:00 • committed by Nicolai Hähnle
parent c8fd7d060d
commit 5d0069eca2
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/gallium/auxiliary/vl/vl_winsys_drm.c
View file

@ -26,6 +26,7 @@
**************************************************************************/
#include <assert.h>
#include <fcntl.h>
#include "pipe/p_screen.h"
#include "pipe-loader/pipe_loader.h"
@ -47,7 +48,7 @@ vl_drm_screen_create(int fd)
if (!vscreen)
return NULL;
if (fd < 0 || (new_fd = dup(fd)) < 0)
if (fd < 0 || (new_fd = fcntl(fd, F_DUPFD_CLOEXEC, 3)) < 0)
goto free_screen;
if (pipe_loader_drm_probe_fd(&vscreen->dev, new_fd))