NeroReflex/mesa
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

glsl: Make sure that packed varyings reflect always_active_io properly.

Browse source 
The always_active_io flag was only set according to the first variable
that got packed in, so NIR io compaction would end up compacting XFB
varyings that shouldn't move at that point.

Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
This commit is contained in:
Eric Anholt 2018-06-21 16:39:15 -07:00
parent ad1a4cb563
commit 6bb046cd29
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/compiler/glsl/lower_packed_varyings.cpp
View file

@ -729,12 +729,17 @@ lower_packed_varyings_visitor::get_packed_varying_deref(
unpacked_var->insert_before(packed_var);
this->packed_varyings[slot] = packed_var;
} else {
ir_variable *var = this->packed_varyings[slot];
/* The slot needs to be marked as always active if any variable that got
* packed there was.
*/
var->data.always_active_io |= unpacked_var->data.always_active_io;
/* For geometry shader inputs, only update the packed variable name the
* first time we visit each component.
*/
if (this->gs_input_vertices == 0 || vertex_index == 0) {
ir_variable *var = this->packed_varyings[slot];
if (var->is_name_ralloced())
ralloc_asprintf_append((char **) &var->name, ",%s", name);
else