NeroReflex/mesa
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

tu: Always print startup failure messages

Browse source 
If we encounter an error during the startup we always want to have
it in the logs to quickly diagnose an issue from user attached logs.

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25888>
This commit is contained in:
Danylo Piliaiev 2023-10-25 15:58:06 +02:00 • committed by Marge Bot
parent 76996e2a94
commit a669147689
2 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/freedreno/vulkan/tu_util.cc
View file

@ -79,7 +79,6 @@ void PRINTFLIKE(3, 4)
VkResult VkResult
__vk_startup_errorf(struct tu_instance *instance, __vk_startup_errorf(struct tu_instance *instance,
VkResult error, VkResult error,
bool always_print,
const char *file, const char *file,
int line, int line,
const char *format, const char *format,
@ -90,11 +89,6 @@ __vk_startup_errorf(struct tu_instance *instance,
const char *error_str = vk_Result_to_str(error); const char *error_str = vk_Result_to_str(error);
#ifndef DEBUG
if (!always_print)
return error;
#endif
if (format) { if (format) {
va_start(ap, format); va_start(ap, format);
vsnprintf(buffer, sizeof(buffer), format, ap); vsnprintf(buffer, sizeof(buffer), format, ap);

4
src/freedreno/vulkan/tu_util.h
View file

@ -67,18 +67,16 @@ tu_env_init(void);
VkResult VkResult
__vk_startup_errorf(struct tu_instance *instance, __vk_startup_errorf(struct tu_instance *instance,
VkResult error, VkResult error,
bool force_print,
const char *file, const char *file,
int line, int line,
const char *format, const char *format,
...) PRINTFLIKE(6, 7); ...) PRINTFLIKE(5, 6);
/* Prints startup errors if TU_DEBUG=startup is set or on a debug driver /* Prints startup errors if TU_DEBUG=startup is set or on a debug driver
* build. * build.
*/ */
#define vk_startup_errorf(instance, error, format, ...) \ #define vk_startup_errorf(instance, error, format, ...) \
__vk_startup_errorf(instance, error, \ __vk_startup_errorf(instance, error, \
TU_DEBUG(STARTUP), \
__FILE__, __LINE__, format, ##__VA_ARGS__) __FILE__, __LINE__, format, ##__VA_ARGS__)
void void