From ae268884da08d430855a9b4ef7873127047dcfe3 Mon Sep 17 00:00:00 2001 From: Sarah Walker Date: Wed, 2 Nov 2022 14:24:55 +0000 Subject: [PATCH] pvr: Fix NULL pointer indirection in pvr_enable_z_replicate() Check input_subpass->depth_stencil_attachment is non-NULL before indirecting it. Signed-off-by: Sarah Walker Reviewed-by: Frank Binns Part-of: --- src/imagination/vulkan/pvr_hw_pass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/imagination/vulkan/pvr_hw_pass.c b/src/imagination/vulkan/pvr_hw_pass.c index 347c22a0d6d..7a0d5cb9541 100644 --- a/src/imagination/vulkan/pvr_hw_pass.c +++ b/src/imagination/vulkan/pvr_hw_pass.c @@ -1488,7 +1488,8 @@ pvr_enable_z_replicate(struct pvr_renderpass_context *ctx, struct pvr_render_subpass *input_subpass = subpass->input_subpass; /* If the subpass writes to the attachment then enable z replication. */ - if (*input_subpass->depth_stencil_attachment == replicate_attach_idx && + if (input_subpass->depth_stencil_attachment && + *input_subpass->depth_stencil_attachment == replicate_attach_idx && !subpass->z_replicate) { subpass->z_replicate = true;