From b44886773c156a0e21109e1431405a8f687989dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tapani=20P=C3=A4lli?= Date: Mon, 26 Feb 2024 14:50:17 +0200 Subject: [PATCH] intel/blorp: disable use of REP16 independent of format MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously we were optimistic and tied this to certain format but wa description lists other formats and bspec clearly disallows the usage. Issue can be seen with different 16bpp tests, effect looks a bit like dithering pattern but it is not, it is just rep16 failing. Fixes: GTF-GL46.gtf42.GL3Tests.texture_storage.texture_storage_texture_as_framebuffer_attachment on DG2 and MTL, some 565 EGL tests on Android and internal issue on game that displays a dither like pattern on the background while it's not supposed to do that. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10646 Cc: mesa-stable Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin Part-of: (cherry picked from commit 1a4f220c29b8ac9d8dbc83eb829e9780cbc1415a) --- .pick_status.json | 2 +- src/intel/blorp/blorp_clear.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index a27948a5eac..59d816471e0 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1474,7 +1474,7 @@ "description": "intel/blorp: disable use of REP16 independent of format", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index 19d3949a4d9..c385baf5c02 100644 --- a/src/intel/blorp/blorp_clear.c +++ b/src/intel/blorp/blorp_clear.c @@ -605,15 +605,17 @@ blorp_clear(struct blorp_batch *batch, if (batch->blorp->isl_dev->info->ver < 6) use_simd16_replicated_data = false; - /* From the BSpec: 47719 Replicate Data: + /* From the BSpec: 47719 (TGL/DG2/MTL) Replicate Data: * * "Replicate Data Render Target Write message should not be used * on all projects TGL+." * + * Xe2 spec (57350) does not mention this restriction. + * * See 14017879046, 14017880152 for additional information. */ if (batch->blorp->isl_dev->info->ver >= 12 && - format == ISL_FORMAT_R10G10B10_FLOAT_A2_UNORM) + batch->blorp->isl_dev->info->ver < 20) use_simd16_replicated_data = false; if (compute)