NeroReflex/mesa
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

i965: Torch public intel_batchbuffer_emit_dword/float helpers.

Browse source 
intel_batchbuffer_emit_float is dead code, it should go.

intel_batchbuffer_emit_dword only had one user, which had bungled using
them by forgetting to call intel_batchbuffer_require_space first.  So it
seems wise to delete these unsafe helpers.

Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
This commit is contained in:
Kenneth Graunke 2018-01-05 12:27:41 -08:00
parent 1c9f1a28c0
commit be144e251c
2 changed files with 2 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/mesa/drivers/dri/i965/intel_batchbuffer.c
View file

@ -692,9 +692,9 @@ brw_finish_batch(struct brw_context *brw)
* necessary by emitting an extra MI_NOOP after the end.
*/
intel_batchbuffer_require_space(brw, 8, brw->batch.ring);
intel_batchbuffer_emit_dword(&brw->batch, MI_BATCH_BUFFER_END);
*brw->batch.map_next++ = MI_BATCH_BUFFER_END;
if (USED_BATCH(brw->batch) & 1) {
intel_batchbuffer_emit_dword(&brw->batch, MI_NOOP);
*brw->batch.map_next++ = MI_NOOP;
}
brw->batch.no_wrap = false;

13
src/mesa/drivers/dri/i965/intel_batchbuffer.h
View file

@ -78,19 +78,6 @@ static inline uint32_t float_as_int(float f)
return fi.d;
}
static inline void
intel_batchbuffer_emit_dword(struct intel_batchbuffer *batch, GLuint dword)
{
*batch->map_next++ = dword;
assert(batch->ring != UNKNOWN_RING);
}
static inline void
intel_batchbuffer_emit_float(struct intel_batchbuffer *batch, float f)
{
intel_batchbuffer_emit_dword(batch, float_as_int(f));
}
static inline void
intel_batchbuffer_begin(struct brw_context *brw, int n, enum brw_gpu_ring ring)
{