From c7f3e736a03c79d55d34a0fe731870060ca1e24f Mon Sep 17 00:00:00 2001 From: Rhys Perry Date: Mon, 12 Feb 2024 16:38:28 +0000 Subject: [PATCH] aco/ra: don't initialize assigned in initializer list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit According to Valgrind, vcc/m0 are uninitialized and this fixes it. Signed-off-by: Rhys Perry Reviewed-by: Daniel Schürmann Cc: mesa-stable Part-of: (cherry picked from commit 53800191a3a7f38e2211768d7f75ebbf5508bf69) --- .pick_status.json | 2 +- src/amd/compiler/aco_register_allocation.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index c9f624d2eb4..37a43841fc1 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1984,7 +1984,7 @@ "description": "aco/ra: don't initialize assigned in initializer list", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null diff --git a/src/amd/compiler/aco_register_allocation.cpp b/src/amd/compiler/aco_register_allocation.cpp index 83960cd5d77..9945362eaa4 100644 --- a/src/amd/compiler/aco_register_allocation.cpp +++ b/src/amd/compiler/aco_register_allocation.cpp @@ -62,7 +62,7 @@ struct assignment { }; uint32_t affinity = 0; assignment() = default; - assignment(PhysReg reg_, RegClass rc_) : reg(reg_), rc(rc_), assigned(-1) {} + assignment(PhysReg reg_, RegClass rc_) : reg(reg_), rc(rc_) { assigned = true; } void set(const Definition& def) { assigned = true;