From ddb4aff2c2ce0d4daa6283d4f7db81a8a58e1465 Mon Sep 17 00:00:00 2001 From: Georg Lehmann Date: Thu, 8 Feb 2024 19:26:11 +0100 Subject: [PATCH] aco/gfx11+: disable v_pk_fmac_f16_dpp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Public docs are apparently wrong: https://github.com/llvm/llvm-project/pull/79598#issuecomment-1933988048 Cc: mesa-stable Reviewed-by: Daniel Schürmann Part-of: (cherry picked from commit e927c5004f9f6305e2269b1b1f0950bcba916ce7) --- .pick_status.json | 2 +- src/amd/compiler/aco_ir.cpp | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.pick_status.json b/.pick_status.json index ea802075c28..9ac328dae63 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -2134,7 +2134,7 @@ "description": "aco/gfx11+: disable v_pk_fmac_f16_dpp", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null diff --git a/src/amd/compiler/aco_ir.cpp b/src/amd/compiler/aco_ir.cpp index ea49a10da5c..a7a9bb9bdd9 100644 --- a/src/amd/compiler/aco_ir.cpp +++ b/src/amd/compiler/aco_ir.cpp @@ -414,6 +414,9 @@ can_use_DPP(amd_gfx_level gfx_level, const aco_ptr& instr, bool dpp instr->opcode == aco_opcode::v_dot2_f32_bf16; } + if (instr->opcode == aco_opcode::v_pk_fmac_f16) + return gfx_level < GFX11; + /* there are more cases but those all take 64-bit inputs */ return instr->opcode != aco_opcode::v_madmk_f32 && instr->opcode != aco_opcode::v_madak_f32 && instr->opcode != aco_opcode::v_madmk_f16 && instr->opcode != aco_opcode::v_madak_f16 &&