NeroReflex/mesa
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

glsl/tests: Catch mkdir errors to help explain when they happen.

Browse source 
A recent pipeline
(1893357) failed
with what looks like an intermittent error related to making files for
the cache test inside of the core of the cache.  Given some of the
errors, it looks like maybe a mkdir failed, so log those errors
earlier so we can debug what's going on next time.

Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4140>
This commit is contained in:
Eric Anholt 2020-03-10 13:36:51 -07:00 • committed by Marge Bot
parent 7d54b84d49
commit e178bca5cc
1 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/compiler/glsl/tests/cache_test.c
View file

@ -230,7 +230,13 @@ test_disk_cache_create(void)
expect_null(cache_exists(cache), "disk_cache_create with XDG_CACHE_HOME set "
"with a non-existing parent directory");
mkdir(CACHE_TEST_TMP, 0755);
err = mkdir(CACHE_TEST_TMP, 0755);
if (err != 0) {
fprintf(stderr, "Error creating %s: %s\n", CACHE_TEST_TMP, strerror(errno));
error = true;
return;
}
cache = disk_cache_create("test", "make_check", 0);
expect_non_null(cache_exists(cache), "disk_cache_create with XDG_CACHE_HOME "
"set");
@ -249,7 +255,13 @@ test_disk_cache_create(void)
expect_null(cache_exists(cache), "disk_cache_create with MESA_GLSL_CACHE_DIR"
" set with a non-existing parent directory");
mkdir(CACHE_TEST_TMP, 0755);
err = mkdir(CACHE_TEST_TMP, 0755);
if (err != 0) {
fprintf(stderr, "Error creating %s: %s\n", CACHE_TEST_TMP, strerror(errno));
error = true;
return;
}
cache = disk_cache_create("test", "make_check", 0);
expect_non_null(cache_exists(cache), "disk_cache_create with "
"MESA_GLSL_CACHE_DIR set");