mesa/src/broadcom
Iago Toral Quiroga 1174f37609 broadcom/compiler: avoid using ldvary sequence to hide latency of branching
This can cause us to stomp the contents of r5 before we have a chance to read
it, like this:

0x3d103186bb800000 nop                           ; nop                         ; ldvary.r0
0x3d105686bbf40000 nop                           ; mov rf26, r5                ; ldvary.r1
0x020000ef0000d000 bu.allna  232, r:unif (0x0000001c / 0.000000)
0x3d1096c6bbf40000 nop                           ; mov rf27, r5                ; ldvary.r2

Here, the MOV in the last instruction is supposed to read r5 produced from
ldvary.r0, but because we have inserted the bu instruction in between now
that read happens at the same time that ldvary.r1 updates r5, stomping the
value we were supposed to read.

Fix this by disallowing injection of a branch instruction in between an ldvary
instruction and its write to the r5 register 2 instructions later.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7062
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19616>
2022-11-09 20:51:25 +00:00
..
ci ci/bare-metal: remove consolidations leftovers 2022-11-09 02:23:37 +00:00
cle broadcom: fix dependencies in static_library() calls 2022-09-14 09:38:28 +00:00
clif
common mesa: Use DEBUG_NAMED_VALUE_END for const struct debug_named_value 2022-11-03 14:40:33 +00:00
compiler broadcom/compiler: avoid using ldvary sequence to hide latency of branching 2022-11-09 20:51:25 +00:00
drm-shim vc4: add DRM_VC4_CREATE_SHADER_BO support to drm-shim 2022-11-08 21:23:27 +00:00
qpu broadcom/compiler: detect unifa write from signal 2022-09-20 06:56:28 +00:00
simulator broadcom/simulator: add a helper to get the amount of free heap memory 2022-09-09 11:14:03 +00:00
vulkan v3dv: use vk_alloc instead of malloc 2022-11-04 09:22:05 +00:00
.editorconfig
meson.build meson: drop duplicate lib in lib name 2022-08-22 08:35:41 +00:00